add request to comment context #95
Conversation
Allows use with dynamically added forms
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
=========================================
+ Coverage 85.03% 85.1% +0.07%
=========================================
Files 16 16
Lines 608 611 +3
=========================================
+ Hits 517 520 +3
Misses 91 91
Continue to review full report at Codecov.
|
| @@ -145,7 +145,8 @@ def get_template_name(self, *tag_args, **tag_kwargs): | |||
| return get_comment_template_name(comment=tag_args[0]) | |||
|
|
|||
| def get_context_data(self, parent_context, *tag_args, **tag_kwargs): | |||
| return get_comment_context_data(comment=tag_args[0]) | |||
| _, request, _ = parent_context | |||
There was a problem hiding this comment.
This can't possibly work on Python 2.
How about request = parent_context.get('request')
| @@ -23,7 +23,7 @@ class AjaxCommentTags(BaseInclusionNode): | |||
| Using the ``@register.inclusion_tag`` is not sufficient, | |||
| because some keywords require custom parsing. | |||
| """ | |||
| template_name = "fluent_comments/templatetags/ajax_comment_tags.html" | |||
| template_name = "comments/ajax_comment_tags.html" | |||
There was a problem hiding this comment.
Why is the template changed?
There was a problem hiding this comment.
to be able to override the template if needed
| $('body').on('mousedown', 'form.js-comments-form :input', setActiveInput); | ||
| $('body').on('submit', 'form.js-comments-form', onCommentFormSubmit); | ||
| $('body').on('click', '.comment-reply-link', showThreadedReplyForm); | ||
| $('body').on('click', '.comment-cancel-reply-link', cancelThreadedReplyForm); |
There was a problem hiding this comment.
Could you make sure the $body is fetched only once?
| @@ -26,14 +26,15 @@ def get_comment_template_name(comment): | |||
| ] | |||
|
|
|||
|
|
|||
| def get_comment_context_data(comment, action=None): | |||
| def get_comment_context_data(comment, action=None, request=None): | |||
There was a problem hiding this comment.
note that get_comment_context_data is called in 3 places, and each one should include the request.
|
Thanks @vdboor, i'll add the changes tonight. |
Fix problems pointed in the PR# 95 comments
|
I'm sorry, I noticed that the JavaScript changes are too invasive. The There have been several unfinished attempts to convert the script to a jQuery plugin format, which would make such re-initialization much easier too. That might be a good starting point implementing this change. Instead, I've fixed the request value elsewhere in 82856c6 |
In my case I needed the request context to check if the user was authenticated to show or not the "reply" link.