Skip to content

Prep release + more pre-commit hooks #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

Conversation

asherf
Copy link
Member

@asherf asherf commented Jun 18, 2025

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares a release by updating version numbers, release notes, and expanding pre-commit hooks support. Key changes include cleaning up the Prometheus YAML configuration, updating the version value from a development tag to a release version, and adding additional hooks in the pre-commit configuration.

Reviewed Changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.

File Description
examples/prometheus/prometheus.yml Removed extraneous '-' characters to simplify YAML structure
django_prometheus/init.py Updated version from "2.4.0.dev0" to "2.4.0" to reflect release
CHANGELOG.md Updated release date and added release notes details
.pre-commit-config.yaml Adjusted quoting style and added new repos for pyupgrade and yamlfmt
Comments suppressed due to low confidence (3)

django_prometheus/init.py:13

  • The version bump from a development tag to a release version should be coordinated with updated release notes to ensure consistency in the release process.
__version__ = "2.4.0"

examples/prometheus/prometheus.yml:5

  • Removal of extraneous '-' characters enhances readability; please verify that the YAML structure remains valid after this cleanup.
    monitor: django-monitor

.pre-commit-config.yaml:11

  • [nitpick] The consistent use of single quotes improves readability; please ensure that similar repo configurations maintain the same quoting style throughout the file.
    rev: '1.25.0'

Signed-off-by: Asher Foa <asher@asherfoa.com>
@asherf asherf merged commit bed0e32 into django-commons:master Jun 18, 2025
5 checks passed
@asherf asherf deleted the release branch June 18, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant