Use default PYTHONWARNINGS setting #2258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly ignores the RedirectPanel's deprecation warning.
Explicitly ignores the RedirectPanel's deprecation warning.
tim-schilling
changed the title
Coverage report
This PR does not seem to contain any modification to coverable code. |
matthiask
approved these changes
Nov 21, 2025
Member
matthiask
left a comment
matthiask
left a comment
There was a problem hiding this comment.
I have to admit I'm confused. -W error would make warnings errors. -W always just makes us show warnings each time they are encountered, not just once per call location.
The tox.ini change makes us not show warnings all the time anymore, and additionally also ignores the redirects panel warning... I think that's fine, since using a warnings eating context manager is hard here.
However, the changelog entry doesn't seem to match what we're doing here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explicitly ignores the RedirectPanel's deprecation warning.
Checklist:
docs/changes.rst.