Skip to content

Add ace.js as local file #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

pietzschke
Copy link

Replace the reference to cdnjs with local file for privacy reasons and no external dependencies (exception in csp must be made)

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2020

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #72   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          162       162           
  Branches         7         7           
=========================================
  Hits           162       162           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd59f81...0090853. Read the comment docs.

@fsbraun
Copy link
Member

fsbraun commented Aug 29, 2022

This is also an issue for djangocms-bootstrap4 and djangocms-frontend (django-cms/djangocms-frontend#48). To solve those dependencies on ace in a common way, I suggest to use PR #123 and add an optional dependency on djangocms-static-ace. If this app is loaded and installed all three djangocms apps using ace should do so locally.

@fsbraun
Copy link
Member

fsbraun commented Aug 29, 2022

Closing this since #123 just got merged. Please reopen if you feel that #123 does not solve your underlying issue! Thanks for submitting of this!

@fsbraun fsbraun closed this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants