Drop python 3.5 and 3.6 & correct changelog #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… django 3.2 support.
|
Looks good, this is also nice. https://adamj.eu/tech/2022/01/11/removing-python-3.6-support-from-my-packages/ Please add python_requires in setup.cfg as well? |
|
@vinitkumar i was keeping this change simple & planning to bring in pre-commit with python & Django upgrade. Hopefully following that I'll have addressed the python requires option. |
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 6 6
Lines 213 213
Branches 44 44
=======================================
Hits 206 206
Misses 4 4
Partials 3 3 Continue to review full report at Codecov.
|
|
@vinitkumar I've added |
vinitkumar
approved these changes
Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop python 3.5 and 3.6 & correct changelog to reflect the unreleased django 3.2 support.