This repository has been archived by the owner on Jul 31, 2020. It is now read-only.
Avoid conflicts with the zabbix_version and zabbix_url variables #303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Pull Request
Hello again,
currently the version of the Zabbix Agent to be installed is indicated by a variable (
zabbix_version
) that has the same name in this role, in zabbix-server and in zabbix-web.This generates some collisions when all roles are used on the same host or group of hosts (the most frequently used case) and makes it impossible to have different agent and server versions (it is necessary in some cases).
This pull request is a solution to this problem, while maintaining backward compatibility with the current variable structure. It's simply proposed to use a new variable,
zabbix_agent_version
, to indicate the version of the agent to be installed and use this variable as a "bypass" for the variable used by the role:Identical reasoning is applied to the variable
zabbix_url
, which can also result in conflicts with the other Zabbix rolesNaturally, to maintain consistency throughout the role kit, the same "bypass" must be performed on
zabbix-server
andzabbix-web
. This pull request is accompanied by two others that I am sending you in minutes.