Skip to content

Conversation

@Kaushal-Dhungel
Copy link
Contributor

@Kaushal-Dhungel Kaushal-Dhungel commented Jun 8, 2021

Describe your changes :


I worked on the issue #162 because changing UserProfile's username was not updating the User model username.

Type of change :

  • Bug fix

Preview (Screenshots) :

If it is possible, please link screenshots of your changes preview !

Checklist:

  • I have read the Code Of Conduct document.
  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@PraveenMalethia @codyseibert

@Kaushal-Dhungel
Copy link
Contributor Author

The commit message should have been "fix #162 ... " but I wrote, "fix #142 ...". Is this a problem??

@Kaushal-Dhungel Kaushal-Dhungel changed the title fix #142 - Changing Username doesn't update the User model username fix #162 - Changing Username doesn't update the User model username Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant