Skip to content

Conversation

stefan-jung
Copy link
Contributor

Migrated org.doctales.ant-contrib to org.jung.ant-contrib.

Signed-off-by: Stefan Jung <stefan.jung@mailbox.org>
@stefan-jung stefan-jung deleted the org.jung.ant-contrib branch October 13, 2024 08:31
@stefan-jung stefan-jung restored the org.jung.ant-contrib branch October 13, 2024 08:32
@stefan-jung stefan-jung reopened this Oct 13, 2024
Signed-off-by: Stefan Jung <stefan.jung@mailbox.org>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefan-jung Instead of deleting this file, you could replace the contents with an alias key, so that anyone looking for the old plug-in name org.doctales.ant-contrib would be redirected to the new plug-in:

{
  "alias": "org.jung.ant-contrib"
}

This feature isn't documented (yet), but you'll find examples in the registry repo, such as pdf2.json.

This approach can be useful in cases where there are previously published links to the old name in places that can't be easily updated.

Of course it's your choice whether you want the plug-ins to be found under the old name — but if you like the idea, you might want to do the same in #158 & #159, and/or any other previously renamed doctales plug-ins.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefan-jung Sorry I dropped the ball here earlier, but after further discussion in recent contributors calls, it turns out the decision not to document the alias function was intentional, as there are apparently unintended side effects where aliases don't work in certain cases.

For that reason, it's best to delete the outdated JSON file as you originally proposed.

Sorry for the delay and extra effort, this was a misunderstanding on my part. 🙇

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@infotexture no worries, thank you so much for your efforts and good ideas.

Signed-off-by: Stefan Jung <stefan.jung@Dometic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants