Skip to content

Conversation

@shaneataylor
Copy link
Contributor

No description provided.

@shaneataylor shaneataylor force-pushed the using_properties_files branch from 454303b to bbf1a7c Compare February 1, 2016 01:30
@infotexture
Copy link
Member

The <filepath> elements that introduce the code blocks in migrating-ant-to-dita.dita might be clearer if preceded with something like “Sample .properties file: ” or “Sample build file: ”.

While the example titles do provide the context, the lowercase paths look a bit lost by themselves.

@infotexture
Copy link
Member

Apart from the comments above, I think this looks like a big improvement.

I'll be happy to merge once you review the comments and push an extra commit to address them.

@shaneataylor
Copy link
Contributor Author

Thanks, @infotexture for the thorough review. I pushed all the suggested changes. 😄

infotexture added a commit that referenced this pull request Feb 8, 2016
Info for the dita command, properties files, migrating ant builds
@infotexture infotexture merged commit d3bc5ad into dita-ot:develop Feb 8, 2016
@infotexture infotexture added the enhancement Changes to an existing topic or feature label Feb 8, 2016
@infotexture infotexture added this to the 2.3 milestone Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Changes to an existing topic or feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants