-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clientside data optimization #269
Draft
nofurtherinformation
wants to merge
14
commits into
main
Choose a base branch
from
query-rendered-features-optimize
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an experimental draft that works to resolve a few issues.
Description
This PR proposes the following solution:
As of 1/31 this only works with Colorado VTDs. There is a button on the top of the menu to toggle RTree vs queryRenderedfeatures. The console will log the average time to query 1000 features in ms. The speed gains here on fast clients are minimal (~6ms average per 1000 features QRF vs 1ms RTree) but on slower machines this becomes pretty meaningful (~30ms QRF vs 3ms RTree). This is aside from the client information/data gains.
So far, Colorado's naive data representation for this is ~450kb once gzip'd and the RBush library is around 2kb gzip'd.
Reviewers
Checklist
Screenshots (if applicable):