-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to go 1.23.1 #1586
upgrade to go 1.23.1 #1586
Conversation
@vcastellm Can you please help review, I can run localtest passed except for the AgentCommand for Election, I think that could be becouse of the macOS ENV issue, I suggest merge this to keep updated, because from any aspects the go v1.16 is too old. goroutine 34 [running]: goroutine 1 [chan receive, 10 minutes]: goroutine 20 [runnable]: goroutine 7 [runnable]: |
Makefile
Outdated
@@ -89,7 +89,8 @@ plugin/types/%.pb.go: proto/%.proto | |||
|
|||
ui: dkron/ui-dist | |||
|
|||
main: dkron/ui-dist plugin/types/dkron.pb.go plugin/types/executor.pb.go *.go */*.go */*/*.go */*/*/*.go | |||
#main: dkron/ui-dist plugin/types/dkron.pb.go plugin/types/executor.pb.go *.go */*.go */*/*.go */*/*/*.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's for local test.
And sorry that I missed this message, a new pull request, please take a review.
@BrainGithub tests are passing in the CI |
Signed-off-by: zx <axpzhang@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
I suggest merge this to keep updated.