Skip to content

Add isort via pre-commit #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2022
Merged

Add isort via pre-commit #2988

merged 2 commits into from
Aug 31, 2022

Conversation

portante
Copy link
Member

@portante portante commented Aug 29, 2022 •
edited
Loading

@portante portante added this to the v0.72 milestone Aug 29, 2022
@portante portante requested a review from dbutenhof August 29, 2022 23:58
@portante portante self-assigned this Aug 29, 2022
@portante portante mentioned this pull request Aug 30, 2022
Merged
riya-17
riya-17 previously approved these changes Aug 30, 2022
View reviewed changes
dbutenhof
dbutenhof reviewed Aug 30, 2022
View reviewed changes
portante
portante commented Aug 30, 2022
View reviewed changes
Copy link
Member Author

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folded in extend_skip change anticipating it in a separate commit.

dbutenhof
dbutenhof reviewed Aug 31, 2022
View reviewed changes
@portante portante requested a review from dbutenhof August 31, 2022 11:55
dbutenhof
dbutenhof previously approved these changes Aug 31, 2022
View reviewed changes
webbnh
webbnh previously approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@portante portante dismissed stale reviews from webbnh and dbutenhof via 75299cd August 31, 2022 15:50
@portante portante requested review from webbnh and dbutenhof August 31, 2022 15:51
webbnh
webbnh approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@webbnh webbnh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub sez nothing changed (other than the squashing), so it's perfect!

@portante portante merged commit 09c1567 into distributed-system-analysis:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webbnh webbnh webbnh approved these changes

@dbutenhof dbutenhof dbutenhof approved these changes

@riya-17 riya-17 Awaiting requested review from riya-17

Assignees

@portante portante

Labels
Code Infrastructure
Projects
None yet
Milestone
v0.72
Development

Successfully merging this pull request may close these issues.
4 participants
@portante @webbnh @riya-17 @dbutenhof