Skip to content
This repository was archived by the owner on Aug 31, 2022. It is now read-only.

Addition of Overview page in the dashboard #105

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Addition of Overview page in the dashboard #105

merged 3 commits into from
Oct 27, 2021

Conversation

anishaswain
Copy link
Collaborator

@anishaswain anishaswain commented Nov 16, 2020 •
edited
Loading

Fixes #90 , #113
Preview till now:
Overview-Pbench-Dashboard

  • Favouriting feature should use result keys
  • Result should be marked as seen upon clicking on them.

@anishaswain anishaswain marked this pull request as draft November 16, 2020 11:56
@anishaswain anishaswain self-assigned this Nov 16, 2020
@anishaswain anishaswain added the Users Of and relating to working with users. label Nov 16, 2020
@anishaswain anishaswain force-pushed the overviewPage branch 2 times, most recently from 60f9df2 to 4be9f88 Compare December 8, 2020 19:40
@anishaswain anishaswain marked this pull request as ready for review December 8, 2020 19:41
@anishaswain anishaswain mentioned this pull request Dec 14, 2020
Closed
@anishaswain anishaswain linked an issue Dec 14, 2020 that may be closed by this pull request
Clicking on "Dashboard" in sidebar opens up the private view #113
Closed
portante
portante suggested changes Jan 28, 2021
View reviewed changes
Copy link
Member

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a bit of clean up.

@aquibbaig
Copy link
Collaborator

@portante We can edit the commit that specifically adds those host names

@anishaswain anishaswain requested a review from portante February 1, 2021 08:23
portante
portante reviewed Feb 1, 2021
View reviewed changes
gurbirkalsi
gurbirkalsi suggested changes Feb 1, 2021
View reviewed changes
aquibbaig
aquibbaig reviewed Feb 2, 2021
View reviewed changes
aquibbaig
aquibbaig reviewed Feb 2, 2021
View reviewed changes
aquibbaig
aquibbaig suggested changes Feb 2, 2021
View reviewed changes
Copy link
Collaborator

@aquibbaig aquibbaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes, but I believe it's coming along pretty well!

portante
portante suggested changes Feb 5, 2021
View reviewed changes
Base automatically changed from master to main February 5, 2021 15:47
portante
portante reviewed Feb 25, 2021
View reviewed changes
Copy link
Member

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we at with addressing the previous comments?

@anishaswain
Copy link
Collaborator Author

Where are we at with addressing the previous comments?

@portante I have addressed all the comments now.

portante
portante suggested changes Feb 25, 2021
View reviewed changes
Copy link
Member

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the TravisCI build is failing.

dbutenhof
dbutenhof previously approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a bunch of comments with small changes and architectural issues that don't necessarily need to be resolved in this PR; we'll need another follow-on PR to integrate this work with the server APIs in any case.

@portante portante dismissed gurbirkalsi’s stale review October 21, 2021 13:06

Gurbir is no longer participating ...

webbnh
webbnh reviewed Oct 21, 2021
View reviewed changes
portante
portante reviewed Oct 21, 2021
View reviewed changes
portante
portante previously approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much to add beyond what Dave pointed out already. Aside from the spelling of a function, and the references to mock-controller in the non-test code, it looks good to go.

@anishaswain anishaswain dismissed stale reviews from portante and dbutenhof via a51eddb October 25, 2021 10:33
@anishaswain anishaswain requested review from webbnh, dbutenhof, gurbirkalsi and portante and removed request for gurbirkalsi October 25, 2021 10:39
dbutenhof
dbutenhof reviewed Oct 25, 2021
View reviewed changes
dbutenhof
dbutenhof previously approved these changes Oct 25, 2021
View reviewed changes
aquibbaig
aquibbaig previously approved these changes Oct 25, 2021
View reviewed changes
Copy link
Collaborator

@aquibbaig aquibbaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Anisha! 🎊

@portante portante mentioned this pull request Oct 25, 2021
Closed
@webbnh webbnh removed their request for review October 25, 2021 18:17
@anishaswain anishaswain dismissed stale reviews from aquibbaig and dbutenhof via d832827 October 27, 2021 11:10
@portante portante merged commit 0c5d010 into distributed-system-analysis:main Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aquibbaig aquibbaig aquibbaig approved these changes

@dbutenhof dbutenhof dbutenhof approved these changes

@portante portante Awaiting requested review from portante

@gurbirkalsi gurbirkalsi Awaiting requested review from gurbirkalsi

@webbnh webbnh Awaiting requested review from webbnh

Assignees

@anishaswain anishaswain

Labels
enhancement New feature or request Users Of and relating to working with users.
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

Clicking on "Dashboard" in sidebar opens up the private view Design overview page for logged in user
6 participants
@anishaswain @aquibbaig @portante @gurbirkalsi @webbnh @dbutenhof