Add type definitions for Recommendations component #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascaton
approved these changes
Jun 23, 2021
|
@lucascaton Thanks for taking a look! I'll merge this now and try to publish a patch tomorrow. |
|
@lucascaton Just published v1.1.1 with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added the missing type definitions for the
Recommendationscomponent and cleaned up the existing definitions to remove unused definitions and resolve the "Statements not allowed in ambient contexts"(#82) error.Motivation and Context
Fixes #104 and #82
Types of changes
Checklist: