Add MANIFEST.in #141
Merged
Add MANIFEST.in #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achille-roussel
approved these changes
Mar 27, 2024
|
I think the canonical way to do this is the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #136 we split the C extension across
frame.cand a few header files.When
setuptoolstries to build the extension it doesn't seem to know about the headers. According to https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html#controlling-files-in-the-distribution we need to bundle aMANIFEST.infile which tells setuptools what files are included in the sdist. The manifest I've provided copies the entire src directory viagraft src. The build now succeeds.