Work around an issue in the coroutine serialization layer #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achille-roussel
approved these changes
Jun 25, 2024
| for _, opt := range d.opts { | ||
| if _, ok := opt.(AnyFunction); ok { | ||
| // No need to serialize these options, since we serialize the | ||
| // map of registered functions directly. |
There was a problem hiding this comment.
Could we file the issue in https://github.com/dispatchrun/coroutine and comment with a link to it here?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a NPE when deserializing function options from #7. For some reason the coroutine serialization layer deserializes them as null.
Let's work around the issue for now in order to make progress. We don't need to serialize the function options because we serialize the function map directly.