dispatchserver package #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dispatchserver/endpoint.go
Outdated
| } | ||
|
|
||
| // Run sends a RunRequest and returns a RunResponse. | ||
| func (c *EndpointClient) Run(ctx context.Context, header http.Header, req dispatch.Request) (dispatch.Response, error) { |
There was a problem hiding this comment.
Have you considered making the header part of the dispatch.Request type instead of passing it into the function each time?
If we don't have a use case for configuring the header differently on each request it could also be a property of EndpointClient to take it out of the Run method signature.
What do you think?
There was a problem hiding this comment.
See dc653d6.
We have a use case upstream where we need to change the header on each request, but we also need to change the signing key too, which is currently set via an option 👍
achille-roussel
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
dispatchserverpackage for use by Dispatch itself when serving its API, and when making requests to an endpoint. Having the server and client live in this repo allows us to use higher level interfaces everywhere, and consolidate request signature generation and validation here (without opening up theinternal/authpackage).There were two components from the
dispatchtestpackage that I've repurposed for the task.