Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid collisions in typed node namespaces, add missing uppercase in alt nodes #1602

Merged
merged 13 commits into from
Oct 3, 2024

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented Sep 28, 2024

Closes #1601 and the issue found in the comments.

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • Updated dynamic module to match generated-code behaviour
  • Added documentation
  • Updated changelog

@kubukoz kubukoz marked this pull request as draft September 28, 2024 18:09
@kubukoz kubukoz marked this pull request as ready for review September 28, 2024 18:37
@Baccata Baccata merged commit 92d56f2 into series/0.18 Oct 3, 2024
11 checks passed
@Baccata Baccata deleted the fix-1601 branch October 3, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADT unions used as traits have unescaped names
2 participants