Add function "AdjustHues" #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function AdjustHue(img, shift) performs a hue shift and returns the changed image img.
Fixes the conversion from the degree to a float value and makes it consistent with most other color pickers.
Adds tests for the AdjustHue function.
Slight change to the AdjustHue function to adjust readability.
Adds an example for the AdjustHue function to the README file.
Changes the name of "AdjustHue" to "AdjustHues" which appears to be the proper term when talking about an entire image (instead of one individual color).
Renames the function "AdjustHues" to "AdjustHue" (along with the tests, documentation and sample files).
Inverts the direction in which the hue is rotated to bring the function in line with the HSL filters in GIMP, Krita and Blender.
Removes the [-180,180] limitation from the hue shift and adds additional test cases for -540, -360, -350, 350, 360, 540, -480 (golden), 480 (golden).
Detects all trivial cases (like -360,0,360) instead of just 0.
|
Okay, I have implemented all the suggestions you made. Hope it's ready for a merge now. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to add a new function for changing/shifting the hues in an image. The functions for converting between RGB and HSL are already in place which makes this a natural next step.
The function 'AdjustHues' gets added along with tests and sample images. The README is updated as well.