DDST-382: Subscriber to handle deletion of related Embargoes when a n… #13
Conversation
| * The Islandora object node being deleted. | ||
| */ | ||
| public function deleteAssociatedCustomEntity(NodeInterface $node): void { | ||
| $custom_entity_storage = $this->entityTypeManager->getStorage('embargo'); |
There was a problem hiding this comment.
This would effectively be creating a dependency on the embargo module, yeah? Probably not desired.
There was a problem hiding this comment.
@adam-vessey please suggest in which module I can implement this. https://github.com/discoverygarden/embargo module?
There was a problem hiding this comment.
Would be more of the target, yes. Still not convinced that such functionality is desired.
Like, something like a scan to find occurrences of ::getEmbargoedNode() that don't account for it being able to be NULL might be more in order?
The ticket is more about error suppression than data maintenance that this PR is getting into, or so I read it. As in, much like discoverygarden/embargo#41 , might also need to hit: https://github.com/discoverygarden/embargo/blob/a075aa4a994472666adf9cdd1af48891fb675323/src/Plugin/search_api/processor/EmbargoJoinProcessor.php#L230
…ode is deleted