Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypasses condition evaluation if retrieved identifier doesn't exist #49

Closed

Conversation

nchiasson-dgi
Copy link
Contributor

No description provided.

@nchiasson-dgi nchiasson-dgi added the patch Backwards compatible bug fixes. label Jun 26, 2024
@nchiasson-dgi nchiasson-dgi marked this pull request as draft June 26, 2024 18:30
@adam-vessey
Copy link
Contributor

Don't think this is particularly appropriate, as it's more treating a symptom than the underlying issue, which is that we have a dependency between configs that is not described on the plugin.

Thinking, something like https://github.com/discoverygarden/dgi_actions/compare/fix/dependency-definitions would result in adding the relevant dependency entries (probably only when whatever relevant entities are resaved), but might not help so much if needing to deal with presently-broken configs.

@jordandukart
Copy link
Contributor

Closing in favor of #50.

@nchiasson-dgi nchiasson-dgi deleted the fix/null-identifier branch July 9, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants