FIX: Completion rate double-count and normalize #33963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
changed the title
nattsw
commented
Jul 30, 2025
| private | ||
|
|
||
| total = get.count | ||
| def self.calculate_completion_per_locale(locale) |
There was a problem hiding this comment.
Still a bit of duplication here per-type but we can de-duplicate when we start finalising other models such as tags or localizing tables from other plugins such as post voting comments.
SamSaffron
reviewed
Jul 30, 2025
| def self.get_completion_per_locale(locale) | ||
| Discourse | ||
| .cache | ||
| .fetch(get_completion_cache_key(locale), expires_in: 1.hour) do |
There was a problem hiding this comment.
I would push this into a const, its a tough recipe to get right, potentially you want to manually expire the cache on certain events.
overall though ... this is super safe, cause at 1 hour the chances of any excessive work are very low.
SamSaffron
approved these changes
Jul 30, 2025
SamSaffron
pushed a commit
that referenced
this pull request
Aug 4, 2025
This PR fixes 2 things. 1. If a `post` was written in `ja` (Japanese) and for some reason also had a `post_localization` that is `ja`, it becomes 200% 2. When getting completion progress for "English (US)", if there exists a "English (UK)" localization, we want to include that 3. Previously the completion count was also getting `post_localization` from posts that are not candidates. If the user switches `ai_translation_backfill_limit_to_public_content` from false to true, it would include previously localized PMs when it should not. Follow up: #33927
martin-brennan
pushed a commit
that referenced
this pull request
Aug 4, 2025
This PR fixes 2 things. 1. If a `post` was written in `ja` (Japanese) and for some reason also had a `post_localization` that is `ja`, it becomes 200% 2. When getting completion progress for "English (US)", if there exists a "English (UK)" localization, we want to include that 3. Previously the completion count was also getting `post_localization` from posts that are not candidates. If the user switches `ai_translation_backfill_limit_to_public_content` from false to true, it would include previously localized PMs when it should not. Follow up: #33927
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 things.
postwas written inja(Japanese) and for some reason also had apost_localizationthat isja, it becomes 200%post_localizationfrom posts that are not candidates. If the user switchesai_translation_backfill_limit_to_public_contentfrom false to true, it would include previously localized PMs when it should not.Follow up: #33927