DEV: Fix flaky test when editing category logo image #33961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
approved these changes
Jul 30, 2025
martin-brennan
pushed a commit
that referenced
this pull request
Aug 4, 2025
Introduced in 497bfec. This test was flaky due to the page having multiple uploaders on the same page, so the `have_css(".uploaded-image-preview.input-xxlarge")` check will always be true for the entire page. It would sometimes work correctly depending on if the uploader managed to finish quickly enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What's This?
See t/158096, introduced in #33423.
This test was flaky due to the page having multiple uploaders on the same page, so the
have_css(".uploaded-image-preview.input-xxlarge")check will always be true for the entire page. It would sometimes work correctly depending on if the uploader managed to finish quickly enough.👑 Testing
The test fails consistently for me with this command:
bin/rspec --fail-fast --tag ~type:multisite --order random:29076 spec/system/admin_customize_themes_spec.rb spec/system/admin_embeddable_hosts_spec.rb spec/system/admin_fonts_spec.rb spec/system/admin_notices_spec.rb spec/system/admin_reports_spec.rb spec/system/admin_site_setting_bulk_action_spec.rb spec/system/admin_site_setting_label_formatting_spec.rb spec/system/admin_site_setting_search_spec.rb spec/system/admin_users_list_spec.rb spec/system/bookmarks_spec.rb spec/system/composer/discard_draft_spec.rb spec/system/composer/post_validation_spec.rb spec/system/composer/review_media_unless_trust_level_spec.rb spec/system/content_localization_spec.rb spec/system/discovery_breadcrumb_navigation_spec.rb spec/system/discovery_list_spec.rb spec/system/edit_category_images_spec.rb spec/system/editing_sidebar_tags_navigation_spec.rb spec/system/ember_deprecation_spec.rb spec/system/emojis/emoji_deny_list_spec.rb spec/system/filtering_topics_spec.rb spec/system/grant_badge_spec.rb spec/system/header_search_spec.rb spec/system/homepage_spec.rb spec/system/interface_color_selector_spec.rb spec/system/keyboard_shortcuts_spec.rb spec/system/network_disconnected_spec.rb spec/system/post_replies_spec.rb spec/system/post_selection_fast_edit_spec.rb spec/system/powered_by_discourse_spec.rb spec/system/request_tracker_spec.rb spec/system/s3_secure_uploads_spec.rb spec/system/social_authentication_spec.rb spec/system/user_activation_spec.rb spec/system/user_activity_posts_spec.rb spec/system/user_page/user_invites_spec.rb spec/system/user_page/user_page_search_spec.rb spec/system/user_page/user_preferences_profile_spec.rb spec/system/viewing_group_members_spec.rb spec/system/viewing_user_private_messages_spec.rb spec/system/welcome_banner_spec.rbIt no longer fails after this fix.