UX: Fix tabs in new notification panel #33871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A followup to #33795 1. the hover effect was broken in Safari (becase it was trying to emulate a backround with a box-shadow of a small child element) 2. in <= 400px height viewports elements were overlapping eachother and icons moved on hover 3. changing `--user-menu-border-width` had issues: at 0px and >=3px icons would move on hover, and increasing the value would make tabs overlap with the border
pmusaraj
approved these changes
Jul 28, 2025
martin-brennan
pushed a commit
that referenced
this pull request
Aug 4, 2025
A followup to #33795 1. the hover effect was broken in Safari (because it was trying to emulate a background by setting a box-shadow of a small child element) <img width="45" height="47" alt="image" src="https://github.com/user-attachments/assets/53deaa3c-d4f5-4b02-ad74-ec464cd12d38" /> 2. in <= 400px height viewports elements were overlapping eachother and icons moved on hover <img width="40" height="64" alt="Screenshot 2025-07-26 at 12 17 21" src="https://github.com/user-attachments/assets/950ef5f0-6d80-418f-b522-78a58730174f" /> 3. changing `--user-menu-border-width` had issues: at 0px and at >= 3px icons would move on hover, and increasing the value would make tabs overlap with the border <img width="49" height="93" alt="image" src="https://github.com/user-attachments/assets/4e514f02-437c-4bfd-8d98-f0dffdfccac5" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A followup to #33795
--user-menu-border-widthhad issues: at 0px and at >= 3px icons would move on hover, and increasing the value would make tabs overlap with the border