refactors header notifications (renders them via separate controller) #1635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 2 of the refactoring described here: #1615
It is mostly code reorganization (plus adding unit tests for everything), behavior is preservad 1:1 with the one small exception: previously when there was no topic title a completely empty link was displayed:
<a href=""></a>
. As such link is "invisible" for the user I thought it will make more sense to not display the link at all, so I generate nothing (empty string) instead in such case.