DEV: Improve logging and fix some formatting errors #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
commented
Jan 9, 2024
| @@ -1,7 +1,7 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| # name: discourse-oauth2-basic | |||
| # about: Allows users to login to your forum using a basic OAuth2 provider. | |||
tgxworld
commented
Jan 9, 2024
| @@ -50,7 +50,7 @@ def recurse(obj, keys) | |||
| class OAuth2FaradayFormatter < Faraday::Logging::Formatter | |||
| def request(env) | |||
| warn <<~LOG | |||
| OAuth2 Debugging: request #{env.method.upcase} #{env.url.to_s} | |||
tgxworld
commented
Jan 9, 2024
| @@ -64,7 +64,7 @@ def response(env) | |||
| warn <<~LOG | |||
| OAuth2 Debugging: response status #{env.status} | |||
|
|
|||
| From #{env.method.upcase} #{env.url.to_s} | |||
tgxworld
force-pushed
the
fix_stree_formatting
branch
from
c731f38 to
78e44d3
Compare
tgxworld
commented
Jan 9, 2024
Comment on lines
+239
to
+244
| request headers: #{headers} | ||
|
|
||
| response status: #{user_json_response.status} | ||
|
|
||
| response body: | ||
| #{user_json_response.body} |
There was a problem hiding this comment.
Things added to the logs
SamSaffron
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.