Skip to content

Update spec to be compliant with after_create_account expectations #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2021
Merged

Update spec to be compliant with after_create_account expectations #53

merged 1 commit into from
Nov 24, 2021

Conversation

angusmcleod
Copy link
Contributor

after_create_account expects an instance of Auth::Result as the second arg. Passing the session data hash instead was previously fine as no logic in after_create_account used instance methods. See further: discourse/discourse#14835 (comment)

@angusmcleod angusmcleod changed the title Update plugin_spec.rb Update spec to be compliant with after_create_account expectations Nov 24, 2021
@angusmcleod angusmcleod mentioned this pull request Nov 24, 2021
Merged
@davidtaylorhq davidtaylorhq merged commit 2303143 into discourse:main Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaylorhq davidtaylorhq davidtaylorhq approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angusmcleod @davidtaylorhq