feat: apply suggestions from code review

Co-authored-by: Antonio Román <kyradiscord@gmail.com>
discordjs · Jun 8, 2021 · bb2854f · bb2854f
1 parent 9ab76f7
commit bb2854f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/examples/music-bot/src/bot.ts b/examples/music-bot/src/bot.ts
@@ -113,10 +113,10 @@ client.on('interaction', async (interaction: Interaction) => {
 			// Attempt to create a Track from the user's video URL
 			const track = await Track.from(url, {
 				onStart() {
-					interaction.followUp(`Now playing!`, { ephemeral: true }).catch(console.warn);
+					interaction.followUp('Now playing!', { ephemeral: true }).catch(console.warn);
 				},
 				onFinish() {
-					interaction.followUp(`Now finished!`, { ephemeral: true }).catch(console.warn);
+					interaction.followUp('Now finished!', { ephemeral: true }).catch(console.warn);
 				},
 				onError(error) {
 					console.warn(error);

diff --git a/examples/music-bot/src/music/subscription.ts b/examples/music-bot/src/music/subscription.ts
@@ -34,7 +34,7 @@ export class MusicSubscription {
 						if (this.voiceConnection.state.status === VoiceConnectionStatus.Disconnected) {
 							this.voiceConnection.reconnect();
 						}
-					}, (this.voiceConnection.reconnectAttempts + 1) * 5e3).unref();
+					}, (this.voiceConnection.reconnectAttempts + 1) * 5_000).unref();
 				} else {
 					this.voiceConnection.destroy();
 				}
@@ -47,7 +47,7 @@ export class MusicSubscription {
 			) {
 				// In the Signalling or Connecting states, set a time limit to prevent starvation
 				// These states can be entered after Ready in an automatic reconnect, e.g. unknown close code, UDP keep-alive failed
-				this.connectPromise = entersState(this.voiceConnection, VoiceConnectionStatus.Ready, 20e3)
+				this.connectPromise = entersState(this.voiceConnection, VoiceConnectionStatus.Ready, 20_000)
 					.then(() => undefined)
 					.catch(() => {
 						if (this.voiceConnection.state.status !== VoiceConnectionStatus.Destroyed) this.voiceConnection.destroy();