This repository was archived by the owner on Oct 5, 2025. It is now read-only.
feat: Sapphire guide #711
Closed
feat: Sapphire guide #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
added
meta: roadmap
This comment has been minimized.
This comment has been minimized.
WiseDevHelper
suggested changes
Jul 15, 2021
Contributor
WiseDevHelper
left a comment
WiseDevHelper
left a comment
There was a problem hiding this comment.
Some small suggestions.
Contributor
|
Additionally, I think the |
guide/sapphire/args.md
Outdated
| - `“` and `”` (iOS smart quotes) | ||
| - `「` and `」` (CJK corner brackets) | ||
|
|
||
| This is troublesome if we want to send quotes in the content, as those would be excluded from `rest`, so we have set quotes to an empty array. This way, when you do `@bot say Hello "there!"`, your bot will send `Hello "there!"`. |
There was a problem hiding this comment.
please put "quotes" in backticks -- to show it's "code" (i.e. it's a field of the class)
There was a problem hiding this comment.
"This is troublesome if we want to send quotes in the content" -> " This is troublesome if we want to send quotes in the content"
megatank58
reviewed
Jul 21, 2021
YorkAARGH
suggested changes
Jul 21, 2021
YorkAARGH
left a comment
YorkAARGH
left a comment
There was a problem hiding this comment.
Nothing major, just a couple of inconsistencies I found whilst following these guides, so far they're good if an idiot like me can follow them!
Danktuary
suggested changes
Jul 25, 2021
Co-authored-by: Wise <45759535+WiseDevHelper@users.noreply.github.com>
Co-Authored-By: Tyler Davis <tgfdavis98@gmail.com>
Co-Authored-By: York <aarghgames@gmail.com>
Co-authored-by: Wise <45759535+WiseDevHelper@users.noreply.github.com>
Co-authored-by: Sanctuary <Danktuary@users.noreply.github.com>
Co-authored-by: Sanctuary <Danktuary@users.noreply.github.com>
kyranet
force-pushed
the
feat/added-sapphire
branch
from
40df0b2 to
aab0601
Compare
Muh9049
reviewed
Aug 10, 2021
Muh9049
reviewed
Aug 10, 2021
Co-authored-by: Muh <52611945+Muh9049@users.noreply.github.com>
Member
|
A Sapphire guide can now be found at https://www.sapphirejs.dev/docs/Guide/getting-started/getting-started |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
As discussed internally with the team, we are replacing Commando with Sapphire, and this takes the first step.
Also, this is my first time contributing to this repository, so please let me know if I did something wrong. I'll also test the changes once I finish writing all the pages 😅