-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rename interaction methods #8832
Open
Syjalo
wants to merge
3
commits into
discordjs:main
Choose a base branch
from
Syjalo:feat/rename-interaction-methods
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+146
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
November 11, 2022 14:17
Codecov Report
@@ Coverage Diff @@
## main #8832 +/- ##
==========================================
+ Coverage 85.22% 85.61% +0.38%
==========================================
Files 77 96 +19
Lines 6715 9459 +2744
Branches 877 1134 +257
==========================================
+ Hits 5723 8098 +2375
- Misses 953 1319 +366
- Partials 39 42 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR renames some interaction methods to not be confused.
.reply()
.deferReply()
.fetchReply()
->.fetchResponse()
.update()
or.deferUpdate()
and then.fetchReply()
, we will get the target message.editReply()
->.editResponse()
.fetchReply()
.deleteReply()
->.deleteResponse()
.fetchReply()
.followUp()
.update()
->.updateMessage()
interaction.update()
), not the target message.deferUpdate()
->.deferMessageUpdate()
.update()
Examples:
Before
After
Status and versioning classification: