feat(Widget): support fetching widget image #8589

dager-mohamed · 2022-09-03T20:53:41Z

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

vercel · 2022-09-03T20:53:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Updated
discord-js	⬜️ Ignored (Inspect)		Oct 10, 2022 at 6:30PM (UTC)
discord-js-guide	⬜️ Ignored (Inspect)		Oct 10, 2022 at 6:30PM (UTC)

packages/discord.js/src/structures/Widget.js

packages/discord.js/typings/index.d.ts

monbrey · 2022-09-04T00:08:01Z

packages/discord.js/src/structures/Widget.js

+  fetchImage(style) {
+    const styles = ['banner1', 'banner2', 'banner3', 'banner4', 'shield'];
+    if (!styles.includes(style)) style = 'shield';
+    const data = `https://discord.com/api/v${APIVersion}${Routes.guildWidgetImage(this.id)}?style=${style}`;


This could be returned directly.

This is not resolved

Still not resolved (original comment: #8589 (comment)) - Also, is there no function for this link in discord-api-types somewhere?

Besides the previous review, this could use RouteBases.api + Routes.guildWidgetImage(this.id) from discord-api-types (need to handle the query string separately)

packages/discord.js/typings/index.d.ts

Co-authored-by: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com>

almeidx · 2022-10-09T23:39:24Z

Are you still maintaining this @dager-mohamed? Seems like there are merge conflicts and unresolved conversations

dager-mohamed · 2022-10-10T05:06:58Z

Are you still maintaining this @dager-mohamed? Seems like there are merge conflicts and unresolved conversations

idk why there are merge conflicts, but there are no resolved conversations

packages/discord.js/src/structures/Widget.js

almeidx · 2022-10-10T08:24:40Z

packages/discord.js/src/structures/Widget.js

+  fetchImage(style) {
+    const styles = ['banner1', 'banner2', 'banner3', 'banner4', 'shield'];
+    if (!styles.includes(style)) style = 'shield';
+    const data = `https://discord.com/api/v${APIVersion}${Routes.guildWidgetImage(this.id)}?style=${style}`;


This is not resolved

packages/discord.js/src/structures/Widget.js

almeidx · 2022-10-10T08:34:31Z

GuildWidgetStyle needs to be added to the APITypes file

Co-authored-by: Almeida <almeidx@pm.me>

vercel · 2022-10-10T13:45:05Z

@dager-mohamed is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

Co-authored-by: Almeida <almeidx@pm.me>

dager-mohamed · 2022-10-10T13:48:32Z

GuildWidgetStyle needs to be added to the APITypes file

all things are done

packages/discord.js/src/structures/Widget.js

almeidx · 2022-10-10T13:50:22Z

packages/discord.js/src/structures/Widget.js

@@ -83,6 +83,16 @@ class Widget extends Base {
    this._patch(data);
    return this;
  }
+
+  /**
+   * Get Guild Widget Image


This is not a great description

packages/discord.js/src/structures/Widget.js

almeidx · 2022-10-10T14:07:24Z

packages/discord.js/src/structures/Widget.js

+  fetchImage(style) {
+    const styles = ['banner1', 'banner2', 'banner3', 'banner4', 'shield'];
+    if (!styles.includes(style)) style = 'shield';
+    const data = `https://discord.com/api/v${APIVersion}${Routes.guildWidgetImage(this.id)}?style=${style}`;


Still not resolved (original comment: #8589 (comment)) - Also, is there no function for this link in discord-api-types somewhere?

packages/discord.js/typings/index.d.ts

Co-authored-by: Almeida <almeidx@pm.me>

dager-mohamed · 2022-10-10T18:10:01Z

now done

Jiralite

There are still conversations that are marked as resolved but are not resolved.

Jiralite · 2022-10-10T18:12:45Z

packages/discord.js/src/structures/Widget.js

+   * @param {GuildWidgetStyle} [style=GuildWidgetStyle.Shield] The style for the widget image
+   * @returns {string}
+   */
+  imageURL(style = GuildWidgetStyle.Shield) {


Why are we defaulting to this? I don't think we should have a default value for this.

dager-mohamed · 2022-10-10T18:17:53Z

There are still conversations that are marked as resolved but are not resolved.

done

Jiralite · 2022-10-10T18:18:53Z

No, not done. Re-review the conversations.

dager-mohamed · 2022-10-10T18:25:16Z

No, not done. Re-review the conversations.

bro where?

Jiralite · 2022-10-10T18:27:58Z

https://github.com/discordjs/discord.js/pull/8589/files#r991311523

You were told it is not a great description (which it is not). You resolved it without making any changes, leaving it to be still a lacklustre description.

https://github.com/discordjs/discord.js/pull/8589/files#r991539399

This ideally shouldn't have a default. I don't see a reason why discord.js should default it.

https://github.com/discordjs/discord.js/pull/8589/files#r962216556

You've been told this one hasn't been resolved multiple times, despite marking it as resolved. No changes have been made here.

Co-authored-by: Almeida <almeidx@pm.me>

almeidx · 2022-10-10T19:01:21Z

packages/discord.js/src/structures/Widget.js

+  fetchImage(style) {
+    const styles = ['banner1', 'banner2', 'banner3', 'banner4', 'shield'];
+    if (!styles.includes(style)) style = 'shield';
+    const data = `https://discord.com/api/v${APIVersion}${Routes.guildWidgetImage(this.id)}?style=${style}`;


Besides the previous review, this could use RouteBases.api + Routes.guildWidgetImage(this.id) from discord-api-types (need to handle the query string separately)

Jiralite · 2023-08-18T15:15:47Z

Superseded by #9782.

github-actions bot added the packages:discord.js label Sep 3, 2022

github-actions bot requested review from iCrawl, kyranet, SpaceEEC and vladfrangu September 3, 2022 20:53

dager-mohamed added 2 commits September 3, 2022 22:55

feat(Widget): support fetching widget image

db79eb7

Update Widget.js

1e9a5a7

Jiralite added semver:minor blocked labels Sep 3, 2022

Jiralite added this to the discord.js v14.4 milestone Sep 3, 2022

Jiralite added the REST label Sep 3, 2022

monbrey requested changes Sep 4, 2022

View reviewed changes

suneettipirneni suggested changes Sep 4, 2022

View reviewed changes

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved

dager-mohamed and others added 3 commits September 4, 2022 09:07

Update packages/discord.js/typings/index.d.ts

620445f

Co-authored-by: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com>

Update Widget.js

ff7a6f3

Update index.d.ts

29023e1

kyranet modified the milestones: discord.js v14.4, discord.js v14.5 Sep 21, 2022

Jiralite modified the milestones: discord.js v14.5, discord.js v14.6 Sep 25, 2022

almeidx requested changes Oct 10, 2022

View reviewed changes

Update packages/discord.js/src/structures/Widget.js

bdf7524

Co-authored-by: Almeida <almeidx@pm.me>

Update packages/discord.js/src/structures/Widget.js

98db690

Co-authored-by: Almeida <almeidx@pm.me>

vercel bot had a problem deploying to Preview – discord-js October 10, 2022 13:45 Failure

Update packages/discord.js/src/structures/Widget.js

946daa1

Co-authored-by: Almeida <almeidx@pm.me>

vercel bot had a problem deploying to Preview – discord-js October 10, 2022 13:45 Failure

Update packages/discord.js/src/structures/Widget.js

512e555

Co-authored-by: Almeida <almeidx@pm.me>

vercel bot had a problem deploying to Preview – discord-js October 10, 2022 13:45 Failure

Merge branch 'main' into widget-patch

1d0713c

vercel bot deployed to Preview – discord-js-guide October 10, 2022 13:51 View deployment

vercel bot deployed to Preview – discord-js October 10, 2022 13:52 View deployment

almeidx requested changes Oct 10, 2022

View reviewed changes

iCrawl modified the milestones: discord.js v14.6, discord.js v14.7 Oct 10, 2022

dager-mohamed and others added 3 commits October 10, 2022 20:08

Update packages/discord.js/src/structures/Widget.js

8ce3f9d

Co-authored-by: Almeida <almeidx@pm.me>

Update packages/discord.js/src/structures/Widget.js

f74529f

Co-authored-by: Almeida <almeidx@pm.me>

Update packages/discord.js/typings/index.d.ts

325efba

Co-authored-by: Almeida <almeidx@pm.me>

Jiralite requested changes Oct 10, 2022

View reviewed changes

Update packages/discord.js/src/structures/Widget.js

f156fec

Co-authored-by: Almeida <almeidx@pm.me>

almeidx requested changes Oct 10, 2022

View reviewed changes

Jiralite removed this from the discord.js v14.7 milestone Nov 3, 2022

Jiralite mentioned this pull request Aug 18, 2023

feat: Support widget image URL #9782

Merged

Jiralite added api support and removed REST labels Aug 18, 2023

Jiralite closed this Aug 18, 2023

almeidx removed the blocked label Oct 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Widget): support fetching widget image #8589

feat(Widget): support fetching widget image #8589

dager-mohamed commented Sep 3, 2022

vercel bot commented Sep 3, 2022 •

edited

Loading

monbrey Sep 4, 2022

almeidx Oct 10, 2022

almeidx Oct 10, 2022 •

edited

Loading

almeidx Oct 10, 2022

almeidx commented Oct 9, 2022

dager-mohamed commented Oct 10, 2022

almeidx Oct 10, 2022

almeidx commented Oct 10, 2022

vercel bot commented Oct 10, 2022

dager-mohamed commented Oct 10, 2022

almeidx Oct 10, 2022

almeidx Oct 10, 2022 •

edited

Loading

dager-mohamed commented Oct 10, 2022

Jiralite left a comment •

edited

Loading

Jiralite Oct 10, 2022

dager-mohamed commented Oct 10, 2022

Jiralite commented Oct 10, 2022

dager-mohamed commented Oct 10, 2022

Jiralite commented Oct 10, 2022

almeidx Oct 10, 2022

Jiralite commented Aug 18, 2023

feat(Widget): support fetching widget image #8589

feat(Widget): support fetching widget image #8589

Conversation

dager-mohamed commented Sep 3, 2022

vercel bot commented Sep 3, 2022 • edited Loading

monbrey Sep 4, 2022

Choose a reason for hiding this comment

almeidx Oct 10, 2022

Choose a reason for hiding this comment

almeidx Oct 10, 2022 • edited Loading

Choose a reason for hiding this comment

almeidx Oct 10, 2022

Choose a reason for hiding this comment

almeidx commented Oct 9, 2022

dager-mohamed commented Oct 10, 2022

almeidx Oct 10, 2022

Choose a reason for hiding this comment

almeidx commented Oct 10, 2022

vercel bot commented Oct 10, 2022

dager-mohamed commented Oct 10, 2022

almeidx Oct 10, 2022

Choose a reason for hiding this comment

almeidx Oct 10, 2022 • edited Loading

Choose a reason for hiding this comment

dager-mohamed commented Oct 10, 2022

Jiralite left a comment • edited Loading

Choose a reason for hiding this comment

Jiralite Oct 10, 2022

Choose a reason for hiding this comment

dager-mohamed commented Oct 10, 2022

Jiralite commented Oct 10, 2022

dager-mohamed commented Oct 10, 2022

Jiralite commented Oct 10, 2022

almeidx Oct 10, 2022

Choose a reason for hiding this comment

Jiralite commented Aug 18, 2023

vercel bot commented Sep 3, 2022 •

edited

Loading

almeidx Oct 10, 2022 •

edited

Loading

almeidx Oct 10, 2022 •

edited

Loading

Jiralite left a comment •

edited

Loading