Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use eslint-config-neon for packages. #8579

Merged
merged 18 commits into from
Sep 1, 2022
Merged

refactor: use eslint-config-neon for packages. #8579

merged 18 commits into from
Sep 1, 2022

Conversation

suneettipirneni
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Adds and conforms to eslint-config-neon

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Sep 1, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Sep 1, 2022 at 6:39PM (UTC)

imranbarbhuiya
imranbarbhuiya suggested changes Sep 1, 2022
View reviewed changes
packages/builders/__tests__/components/components.test.ts Outdated Show resolved Hide resolved
packages/builders/__tests__/components/selectMenu.test.ts Outdated Show resolved Hide resolved
packages/builders/package.json Outdated Show resolved Hide resolved
packages/discord.js/package.json Outdated Show resolved Hide resolved
packages/docgen/src/cli.ts Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 1, 2022 •
edited
Loading

Codecov Report

Merging #8579 (4dca8f8) into main (4bdb059) will decrease coverage by 0.05%.
The diff coverage is 87.91%.

@@            Coverage Diff             @@
##             main    #8579      +/-   ##
==========================================
- Coverage   86.43%   86.37%   -0.06%     
==========================================
  Files          87       87              
  Lines        8550     8647      +97     
  Branches     1105     1107       +2     
==========================================
+ Hits         7390     7469      +79     
- Misses       1117     1136      +19     
+ Partials       43       42       -1
Flag Coverage Δ
builders 100.00% <100.00%> (ø)
collection 100.00% <100.00%> (ø)
proxy 74.10% <75.00%> (+0.81%) ⬆️
rest 91.96% <89.13%> (+0.07%) ⬆️
utilities 100.00% <100.00%> (ø)
voice 63.86% <45.09%> (-0.22%) ⬇️
ws 60.57% <85.08%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/proxy/src/util/responseHelpers.ts 90.16% <0.00%> (ø)
packages/proxy/src/util/util.ts 0.00% <0.00%> (ø)
packages/rest/src/lib/handlers/IHandler.ts 0.00% <0.00%> (ø)
packages/voice/src/audio/AudioPlayerError.ts 0.00% <ø> (ø)
packages/voice/src/audio/AudioResource.ts 95.23% <ø> (ø)
packages/voice/src/audio/PlayerSubscription.ts 50.00% <ø> (ø)
packages/voice/src/networking/VoiceWebSocket.ts 0.00% <0.00%> (ø)
packages/voice/src/receive/SSRCMap.ts 86.20% <ø> (ø)
packages/voice/src/receive/SpeakingMap.ts 100.00% <ø> (ø)
packages/voice/src/receive/VoiceReceiver.ts 90.56% <ø> (ø)
... and 72 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel vercel bot temporarily deployed to Preview September 1, 2022 15:42 Inactive
imranbarbhuiya
imranbarbhuiya suggested changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@imranbarbhuiya imranbarbhuiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these 4 changes needed. Else LGTM

packages/builders/src/components/Components.ts Outdated Show resolved Hide resolved
packages/builders/src/interactions/slashCommands/Assertions.ts Outdated Show resolved Hide resolved
packages/builders/src/interactions/slashCommands/SlashCommandSubcommands.ts Outdated Show resolved Hide resolved
packages/docgen/package.json Show resolved Hide resolved
iCrawl
iCrawl requested changes Sep 1, 2022
View reviewed changes
packages/api-extractor-utils/src/parse.ts Outdated Show resolved Hide resolved
packages/builders/__tests__/components/button.test.ts Outdated Show resolved Hide resolved
packages/builders/__tests__/components/components.test.ts Outdated Show resolved Hide resolved
packages/builders/__tests__/components/selectMenu.test.ts Outdated Show resolved Hide resolved
packages/builders/__tests__/interactions/ContextMenuCommands.test.ts Outdated Show resolved Hide resolved
packages/ws/src/strategies/sharding/WorkerShardingStrategy.ts Outdated Show resolved Hide resolved
packages/ws/src/strategies/sharding/worker.ts Outdated Show resolved Hide resolved
packages/ws/src/utils/constants.ts Outdated Show resolved Hide resolved
packages/ws/src/ws/WebSocketManager.ts Outdated Show resolved Hide resolved
packages/ws/src/ws/WebSocketShard.ts Outdated Show resolved Hide resolved
@iCrawl iCrawl merged commit edadb9f into discordjs:main Sep 1, 2022
cyan-2048 pushed a commit to cyan-2048/discord.js that referenced this pull request May 8, 2024
@suneettipirneni @iCrawl
refactor: use eslint-config-neon for packages. (discordjs#8579)
2b3678e 
Co-authored-by: Noel <buechler.noel@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imranbarbhuiya imranbarbhuiya imranbarbhuiya approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner

Assignees
No one assigned
Labels
packages:builders packages:collection packages:docgen packages:proxy packages:proxy-container packages:rest packages:voice packages:ws refactor semver:patch
Projects
discord.js
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suneettipirneni @iCrawl @imranbarbhuiya @Jiralite