Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump vitest and add @vitest/coverage-c8 #8507

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

imranbarbhuiya
Copy link
Contributor

@imranbarbhuiya imranbarbhuiya commented Aug 17, 2022

Please describe the changes this PR makes and why it should be merged:
Bumped vitest to 0.22.0 and added @vitest/coverage-c8
ref: https://github.com/vitest-dev/vitest/releases/tag/v0.22.0

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Aug 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Aug 17, 2022 at 3:02AM (UTC)

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #8507 (95b2918) into main (a1dddd6) will decrease coverage by 0.20%.
The diff coverage is 17.39%.

@@            Coverage Diff             @@
##             main    #8507      +/-   ##
==========================================
- Coverage   86.49%   86.29%   -0.21%     
==========================================
  Files          87       87              
  Lines        8339     8362      +23     
  Branches     1104     1105       +1     
==========================================
+ Hits         7213     7216       +3     
- Misses       1083     1103      +20     
  Partials       43       43              
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 73.28% <ø> (ø)
rest 92.53% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 64.08% <ø> (ø)
ws 59.54% <17.39%> (-0.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/ws/src/ws/WebSocketShard.ts 22.41% <0.00%> (-0.45%) ⬇️
packages/ws/src/ws/WebSocketManager.ts 95.60% <27.27%> (-2.99%) ⬇️
packages/ws/src/utils/utils.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ckohen ckohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While not strictly necessary since c8 is default, maybe we should specify for clarity https://vitest.dev/guide/coverage.html#coverage-providers

build.config.ts Outdated
@@ -37,6 +37,7 @@ export function createUnbuildConfig({
return defineBuildConfig({
entries,
clean: true,
failOnWarn: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unrelated to this change?

@github-actions github-actions bot removed the chore label Aug 17, 2022
@iCrawl iCrawl merged commit d97cd93 into discordjs:main Aug 17, 2022
@imranbarbhuiya imranbarbhuiya deleted the chore/bump-deps branch August 17, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants