-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(RequestHandler): only reset tokens for authenticated 401s #7508
fix(RequestHandler): only reset tokens for authenticated 401s #7508
Conversation
Instead of passing around an extra property everywhere, can you not just check for the Authorization Header? I know a user can technically override it when passing auth: false, but that's not supported |
We'd have to normalize the headers to always be lowercased no matter if we or users provided it I suppose... Bit of a pitfall of how we pass data down from the manager to the handler |
What do you mean by that? the header is passed as Authorization, not authorization |
Please describe the changes this PR makes and why it should be merged:
Closes #7492 by resetting the token only when an authorized request fails with a 401.
Status and versioning classification: