refactor: Strengthen channel typings in appropriate places #6232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I noticed there's a bunch of other places where the typings can be strengthened, so I'm going to add the following and apply them to hopefully everywhere with no missed instances:
|
Jiralite
changed the title
CategoryChannelResolvable in appropriate places
kyranet
requested changes
Jul 30, 2021
vladfrangu
approved these changes
Jul 30, 2021
kyranet
approved these changes
Jul 30, 2021
Favouring "disconnect" here instead of "kick" as it is consistent with the documentation in VoiceState#setChannel().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Per #5521, methods and typings that were solely for category channels (and ids) were instead allowing any channel to go through instead of just
CategoryChannelResolvable. This pull request should address this and resolve #5521.Additionally, this pull request changes the type definition for
ChannelData. Before, it only could take the parent id (Snowflake) of a potential category channel, but now, it is possible to take aCategoryChannelResolvableinstead. This means a rename is in order, so I've changedparentIdhere to justparent. This also makes it a breaking change, but this also matches nicely now with theGuildChannelCreateOptionstype definition!Status and versioning classification: