Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Managers): ✨ Add GuildInviteManager #5889

Merged
merged 36 commits into from
Jul 4, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
ed777ff
feat(Managers): ✨ Add GuildInviteManager
DraftProducts Jun 20, 2021
9f6f82e
types(GuildInviteManager) Fix pluralization of class name in typings
DraftProducts Jun 20, 2021
c576e4b
refactor: 💬 Adds literary corrections
DraftProducts Jun 20, 2021
f97bcc5
refactor: 🥅 Transform sync errors to Promise rejections
DraftProducts Jun 20, 2021
921c81f
fix: 🐛 Remove mutating in case of options is a frozen object
DraftProducts Jun 20, 2021
8bfd39a
types: 🏷️ Replace InviteOptions with CreateInviteOptions
DraftProducts Jun 20, 2021
3bc3be9
refactor(Errors): 🥅 Change "unknown invite" error to avoid confusion …
DraftProducts Jun 20, 2021
1890cd1
fix(Errors): Update quotes & formulation
DraftProducts Jun 21, 2021
8b727b8
docs: Provide more details in docs about invite creation
DraftProducts Jun 22, 2021
186b152
refactor: ♻️ Move channel parameter to options
DraftProducts Jun 22, 2021
ae9916d
types(options): 🏷️ Fix options types
DraftProducts Jun 22, 2021
edced3a
refactor: Change [] to ()
DraftProducts Jun 23, 2021
357dd09
style: 🚨 Lint suggest & typings
DraftProducts Jun 23, 2021
8aacbd9
refactor: Some suggested corrections on typings & typedoc
DraftProducts Jun 23, 2021
4d1cbf0
refactor: ♻️ Change return value of delete method to void
DraftProducts Jun 24, 2021
0900a51
fix: 📝 Remove uncertain return value of doc
DraftProducts Jun 24, 2021
dcacf1c
fix: 🐛 If "options" is a string, it's not needed to continue
DraftProducts Jun 24, 2021
92e74ef
perf: ⚡️ Remove double channel resolution
DraftProducts Jun 24, 2021
ddbb26d
perf: ⚡️ Use Permissions flags instead of string
DraftProducts Jun 24, 2021
e2992b6
types: 🏷️ Change GuildChannel to GuildChannelResolvable
DraftProducts Jun 24, 2021
6baef14
docs: 📝 Remove personnal invites of examples
DraftProducts Jun 25, 2021
546a73c
refactor(Guild): 🔥 Remove 'Guild#fetchInvites' method
DraftProducts Jun 27, 2021
8173ad0
refactor: ♻️ Refactor of review
DraftProducts Jun 30, 2021
a189ae6
fix: 🏷️ Fix tslint warnings
DraftProducts Jun 30, 2021
d12db15
refactor(Errors): Remove unused errors
DraftProducts Jul 3, 2021
d713efb
docs(GuildInviteManager): 📝 Correct errors in typedoc descriptions
DraftProducts Jul 3, 2021
7844337
refactor: ♻️ Remove useless type check
DraftProducts Jul 3, 2021
c735461
docs(GuildInviteManager): Simplification of typedoc return schem
DraftProducts Jul 3, 2021
bff9de7
refactor: ⚡️ Improve GuildChannel#fetchInvites with GuildInviteManage…
DraftProducts Jul 3, 2021
70423b6
docs(GuildInviteManager): 🏷️ Fix cache option typing
DraftProducts Jul 3, 2021
a1d8509
fix: 🚑 Fix breaking changes in GuildAuditLogs initialization
DraftProducts Jul 3, 2021
8bc7fd6
Merge branch 'master' into feature-invite-manager
DraftProducts Jul 3, 2021
5be49e9
feat(GuildChannel): ✨ Add cache option to GuildChannel#fetchInvites
DraftProducts Jul 3, 2021
bb0b368
Merge branch 'master' into feature-invite-manager
DraftProducts Jul 4, 2021
3135046
refactor(GuildInviteManager): ♻️ Add changes due to methods changes
DraftProducts Jul 4, 2021
bdcceb0
types(GuildInviteManager): 🏷️ Fix typings due to external changes
DraftProducts Jul 4, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
types: 🏷️ Change GuildChannel to GuildChannelResolvable
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
  • Loading branch information
DraftProducts and NotSugden committed Jun 24, 2021
commit e2992b67f6690bde11d24d3e492e2cf009333718
2 changes: 1 addition & 1 deletion src/managers/GuildInviteManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ class GuildInviteManager extends BaseManager {

/**
* @typedef {CreateInviteOptions} CreateChannelInviteOptions
* @property {GuildChannel} [channel] The optional channel to define where to create the invite.
* @property {GuildChannelResolvable} [channel] The optional channel to define where to create the invite.
*/

/**
Expand Down
2 changes: 1 addition & 1 deletion typings/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3026,7 +3026,7 @@ declare module 'discord.js' {
}

interface CreateChannelInviteOptions extends CreateInviteOptions {
channel: GuildChannel;
channel: GuildChannelResolvable;
}

interface FetchInviteOptions extends BaseFetchOptions {
Expand Down