feat(Guild): setChannelPositions parent, lockPermissions keys #5507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: almostSouji <timoqueezle@gmail.com>
kyranet
requested changes
Apr 9, 2021
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
kyranet
approved these changes
Apr 9, 2021
iCrawl
approved these changes
Apr 11, 2021
vladfrangu
reviewed
Apr 11, 2021
SpaceEEC
approved these changes
Apr 30, 2021
iCrawl
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Guild#setChannelPositionstakes the optionsparentandlockPermissionsas per chore: document missing properties in Modify Channel Positions endpoint discord/discord-api-docs#1776positionkey optional, however is still only a patch level PR, since the old approach (position being mandatory) can still be used, making this non-breaking.Status and versioning classification: