-
-
Notifications
You must be signed in to change notification settings - Fork 4k
feat(Shard): shard-specific broadcastEval/fetchClientValues + shard Id util #4991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jonahsnider
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code probably works but I have a few minor suggestions with the shardIdForGuildId function.
jonahsnider
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New edits look good.
SpaceEEC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Please describe the changes this PR makes and why it should be merged:
Adds the ability to call
broadcastEvalandfetchClientValuesfrom a shard to run on different target shard, instead of broadcasting to all and using anifin the given script to filter by shard.Now you can target a shard directly:
We get back
[JetBrains Community, 1, 0], so we can see it correctly went to the target shard and found the guild there.Status
Semantic versioning classification: