-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Activity): add missing fields #4984
Conversation
Co-authored-by: Jan <66554238+Vaporox@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for the linked PR to land first, but if there are no further changes, LGTM.
@Vaporox all the other ones use |
Because we landed requirement for Node.js v14 (which implements |
So will we use |
That's correct. |
oh looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, once the upstream PR is merged.
Please describe the changes this PR makes and why it should be merged:
Adds
id
,platform
,syncID
,sessionID
, andbuttons
to the Activity object (discord/discord-api-docs#2219)wasn't sure if I should do something for ClientPresence because bots can't send these, but it seems to already have code to handle many properties that bots can't send [msg]
Status
Semantic versioning classification: