Skip to content

fix(Action): attempt to get a User if GuildMember not returned #4922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2020
Merged

fix(Action): attempt to get a User if GuildMember not returned #4922

merged 2 commits into from
Oct 24, 2020

Conversation

@monbrey
Copy link
Member

@monbrey monbrey commented Oct 20, 2020

Fixes #4921

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@monbrey monbrey changed the title fix(MessageReactionAdd): revert change introduced in 4791 fix(Action): attempt to get a User if GuildMember not returned Oct 20, 2020
@kyranet kyranet requested a review from vladfrangu October 20, 2020 12:18
@iCrawl iCrawl merged commit 3d158f4 into discordjs:master Oct 24, 2020
@monbrey monbrey deleted the patch-4921 branch November 23, 2020 02:37
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Client#messageReactionAdd now relies on the GUILD_MEMBER partial

4 participants

@monbrey @vladfrangu @iCrawl @kyranet