fix(GuildMemberManager): Use actually random nonce in fetch #4884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
requested changes
Oct 3, 2020
kyranet
approved these changes
Oct 12, 2020
vladfrangu
requested changes
Oct 12, 2020
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
vladfrangu
approved these changes
Oct 12, 2020
SpaceEEC
approved these changes
Oct 13, 2020
iCrawl
approved these changes
Oct 17, 2020
GiorgioBrux
pushed a commit
to GiorgioBrux/discord.js
that referenced
this pull request
Oct 17, 2020
…s#4884) Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Fixes #4883
If you call the function mulltiple times immediately after another (within the same millisecond), both request would have the same nonce, resulting in the second request resulting with the data of the first request.
To fix this, make sure to use an actually random nonce when fetching members.
Status
Semantic versioning classification: