Skip to content

fix(GuildChannel): make setTopic argument nullable #4875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2020
Merged

fix(GuildChannel): make setTopic argument nullable #4875

merged 1 commit into from
Oct 17, 2020

Conversation

@yuta0801
Copy link
Contributor

@yuta0801 yuta0801 commented Oct 2, 2020

Please describe the changes this PR makes and why it should be merged:
Modify Channel API accepts null for topic to unset it, and already we can use channel.setTopic(null) in discord.js.
This PR document the method accept null and fix typing.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vladfrangu vladfrangu requested review from iCrawl and kyranet October 2, 2020 08:54
@iCrawl iCrawl merged commit b9ad510 into discordjs:master Oct 17, 2020
GiorgioBrux pushed a commit to GiorgioBrux/discord.js that referenced this pull request Oct 17, 2020
@yuta0801 @GiorgioBrux
fix(GuildChannel): make setTopic argument nullable (discordjs#4875)
7400c00
@yuta0801 yuta0801 deleted the nullable-topic branch October 24, 2020 04:27
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yuta0801 @vladfrangu @iCrawl @kyranet @SpaceEEC