Skip to content

Conversation

@tguichaoua
Copy link
Contributor

@tguichaoua tguichaoua commented Aug 28, 2020

Please describe the changes this PR makes and why it should be merged:
resolve #4753

Move prettier config into .prettierrc file. Allow VS Code prettier plugin to correctly format files.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@tipakA
Copy link
Contributor

tipakA commented Aug 28, 2020

#3900 Probably still applies here

@tguichaoua
Copy link
Contributor Author

#3900 Probably still applies here

If it's a problem, it's possible to move config into the package.json.

Copy link
Contributor

@papaia papaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be changed too

"*.ts": "prettier --write --single-quote --print-width 120 --trailing-comma all --end-of-line lf --arrow-parens avoid"

tguichaoua and others added 3 commits August 28, 2020 12:04
Co-authored-by: Papaia <43409674+Papaia@users.noreply.github.com>
Co-authored-by: Papaia <43409674+Papaia@users.noreply.github.com>
@papaia
Copy link
Contributor

papaia commented Aug 28, 2020

#3900 Probably still applies here

If it's a problem, it's possible to move config into the package.json.

I believe you should move it to the prettier field in package.json for consistency.

@tguichaoua tguichaoua changed the title chore(Prettier): add .prettierrc file chore(Prettier): add settings for prettier plugin Aug 28, 2020
@iCrawl iCrawl merged commit b48b782 into discordjs:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add .prettierrc file

4 participants