fix: set #nickname to null as the default value #4641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Please describe the changes this PR makes and why it should be merged:** * closes discordjs#4640 According to discordjs#4640, the `.nickname` property of a guildmember returns `undefined` instead of `null` if not present. This might be due to the way the library currently handles and assigns the initial `data` payload received from Discord itself. **Status** - [x] Code changes have been tested against the Discord API, or there are no code changes - [x] I know how to update typings and have done so, or typings don't need updating **Semantic versioning classification:** - [ ] This PR changes the library's interface (methods or parameters added) - [ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed) - [ ] This PR only includes non-code changes, like changes to documentation, README, etc.
kyranet
requested changes
Jul 17, 2020
PASTUSEDBY
changed the title
vladfrangu
approved these changes
Aug 11, 2020
kyranet
approved these changes
Aug 11, 2020
iCrawl
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
According to #4640, the
.nicknameproperty of a guildmember returnsundefinedinstead ofnullif not present.This might be due to the way the library currently handles and assigns the initial
datapayload received from Discord itself.Status
Semantic versioning classification: