Skip to content

Conversation

@almostSouji
Copy link
Member

@almostSouji almostSouji commented Jun 27, 2020

Please describe the changes this PR makes and why it should be merged:

An oversight in two positions leads to allowedMentions being ignored when splitOptions are present.

Breakdown of changes

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl requested a review from SpaceEEC July 17, 2020 08:19
@iCrawl iCrawl merged commit a663ea4 into discordjs:master Aug 11, 2020
@almostSouji almostSouji deleted the split-mentions branch September 27, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

using message split ignores message options

4 participants