docs(Client): fix docs for login method #4350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Maybe use an |
NotSugden
suggested changes
Jun 11, 2020
Contributor
Author
|
@NotSugden That seemed like a better approach to me, just implemented it with the most recent commit |
infiniwave
approved these changes
Jun 18, 2020
infiniwave
left a comment
infiniwave
left a comment
There was a problem hiding this comment.
Sounds like good idea! Some people might never know that discord.js gets the env variable.
DraftProducts
approved these changes
Jun 24, 2020
DraftProducts
approved these changes
Jun 24, 2020
Mesteery
approved these changes
Jul 30, 2020
vladfrangu
previously requested changes
Aug 11, 2020
vaporoxx
commented
Aug 11, 2020
kyranet
approved these changes
Aug 11, 2020
iCrawl
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR fixes the documentation for
Client#loginby marking thetokenparameter as optional and adding a small description.Status
Semantic versioning classification: