Skip to content

fix(Guild): change wrong description & call fetchVanityData internally #4335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2020
Merged

fix(Guild): change wrong description & call fetchVanityData internally #4335

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f7f2f4
docs(vanityURLUses): use fetchVanityData
papaia Jun 4, 2020
c27dadb
feat(fetchVanityCode): internally call fetchVanityData
papaia Jun 4, 2020
8aa47a2
Update src/structures/Guild.js
SpaceEEC Jun 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/structures/Guild.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ class Guild extends Base {
/* eslint-disable max-len */
/**
* The use count of the vanity URL code of the guild, if any
* <info>You will need to fetch the guild using {@link Guild#fetchVanityCode} if you want to receive this parameter</info>
* <info>You will need to fetch this parameter using {@link Guild#fetchVanityData} if you want to receive it</info>
* @type {?number}
*/
this.vanityURLUses = null;
Expand Down Expand Up @@ -771,13 +771,7 @@ class Guild extends Base {
* .catch(console.error);
*/
fetchVanityCode() {
if (!this.features.includes('VANITY_URL')) {
return Promise.reject(new Error('VANITY_URL'));
}
return this.client.api
.guilds(this.id, 'vanity-url')
.get()
.then(res => res.code);
return this.fetchVanityData().then(vanity => vanity.code);
}

/**
Expand Down