Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PacketHandler): guild members chunk packet handler should… #4092

Merged
merged 1 commit into from
Apr 19, 2020
Merged

fix(PacketHandler): guild members chunk packet handler should… #4092

merged 1 commit into from
Apr 19, 2020

Conversation

RDambrosio016
Copy link
Contributor

@RDambrosio016 RDambrosio016 commented Apr 17, 2020 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
#3562 added the withPresences option to the guild members manager's fetch method, however it incorrectly calls
guild.presences.cache.add(...)
it should be calling
guild.presences.add(...)
This pr fixes that which fixes #4091
Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl changed the title fix(packet handler): guild members chunk packet handler should call .presences.add not .presences.cache.add fix(PacketHandler): guild members chunk packet handler should… Apr 19, 2020
@iCrawl iCrawl merged commit 5af1a55 into discordjs:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@papaia papaia papaia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New withPresences: true tries to add to cache, "add is not a function"
4 participants
@RDambrosio016 @iCrawl @papaia @SpaceEEC