Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ClientApplication): type fetchAssets as resolving with an array #4078

Merged

Conversation

SpaceEEC
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

This PR fixes the return type of ClientApplication#fetchAssets in your type declarations.
It incorrectly stated that it would return a Promise<ClientApplicationAsset> instead of Promise<ClientApplicationAsset[]>.

Fixes #4026.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl merged commit 72a7f2b into discordjs:master Apr 16, 2020
@SpaceEEC SpaceEEC deleted the typings/client_application_fetch_assets branch November 1, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing of ClientApplication#fetchAssets is incorrect
2 participants