Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RoleStore, ChannelStore): fetch() method #3071

Merged
merged 3 commits into from
Feb 9, 2019
Merged

feat(RoleStore, ChannelStore): fetch() method #3071

merged 3 commits into from
Feb 9, 2019

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Feb 9, 2019

Please describe the changes this PR makes and why it should be merged:

Adds a fetch() method to RoleStore and ChannelStore for consistency with MessageStore, GuildMemberStore, ReactionUserStore, UserStore...

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@amishshah amishshah merged commit c432591 into discordjs:master Feb 9, 2019
@kyranet kyranet deleted the role-channel-stores-fetch branch February 9, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amishshah amishshah amishshah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyranet @amishshah @SpaceEEC